Fix restoration of mock getters #2018
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a mock was configured we captured its value and replaced it with the mocked value, then put the value back when the tests were complete. However by capturing and resetting the value, we lost metadata about the property such as its `writable` or `configurable` state. This would break certain types of objects if they were to be used by subsequent tests that had non-standard property definitions.
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a mock was configured we captured its value and replaced it with the mocked value, then put the value back when the tests were complete.
However by capturing and resetting the value, we lost metadata about the property such as its
writableorconfigurablestate. This would break certain types of objects if they were to be used by subsequent tests that had non-standard property definitions.Tasks
[ ] Required tests have been written[ ] Documentation has been updated[ ] Added an entry to CHANGELOG.md if applicable